Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix README and dev/deploy.yaml #261

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

tyler-lloyd
Copy link
Contributor

  • current readme link is a 404
  • without the new doc indicator in dev/deploy.yaml, the manifest.yaml from the release doesn't separate the deployment and the synthesizer CRD so the synthesizer CRD isn't deployed when running kubectl apply -f "https://github.com/Azure/eno/releases/download/${TAG}/manifest.yaml"

example of synthesizer CRD missing when running the commands from the README

➜  ~ kubectl apply -f "https://github.com/Azure/eno/releases/download/${TAG}/manifest.yaml"
customresourcedefinition.apiextensions.k8s.io/compositions.eno.azure.io created
customresourcedefinition.apiextensions.k8s.io/resourceslices.eno.azure.io created
customresourcedefinition.apiextensions.k8s.io/symphonies.eno.azure.io created
deployment.apps/eno-controller created
deployment.apps/eno-reconciler created
serviceaccount/eno created
clusterrolebinding.rbac.authorization.k8s.io/eno-cluster-admin created

➜  ~ k get crds | grep eno
compositions.eno.azure.io                             2025-01-06T15:15:01Z
resourceslices.eno.azure.io                           2025-01-06T15:15:01Z
symphonies.eno.azure.io                               2025-01-06T15:15:01Z

when running kubectl apply -f "https://github.com/Azure/eno/releases/download/${TAG}/manifest.yaml" there is no separator between the Deployment and the Synthesizer CRD doc
@AYM1607 AYM1607 merged commit acbf639 into Azure:main Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants