Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reconciliation resource version cache #252

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

AYM1607
Copy link
Contributor

@AYM1607 AYM1607 commented Nov 20, 2024

Simplify this code to make it easier to reason about, also fixes a bug where resources were being marked as deleted in the resourceslice status on every resource version cache hit.

Copy link
Collaborator

@jveski jveski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@AYM1607 AYM1607 merged commit ac0e943 into main Nov 21, 2024
25 checks passed
@AYM1607 AYM1607 deleted the remove-resource-version-cache branch November 21, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants