Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patch edgecases #242

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix patch edgecases #242

merged 2 commits into from
Nov 6, 2024

Conversation

jveski
Copy link
Collaborator

@jveski jveski commented Nov 5, 2024

Values that change on the server side should not cause the patch to be continuously applied. There are two known cases where this can occur: bools explicitly set to false, and resource quantities.

Jordan Olshevski added 2 commits November 5, 2024 18:29
@jveski jveski enabled auto-merge (squash) November 5, 2024 22:34
AYM1607
AYM1607 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@AYM1607 AYM1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is perfectly reasonable to unblock our current efforts, but we should create an issue to track an implementation of a dynamic runtime approach...

@jveski jveski merged commit 7546c62 into main Nov 6, 2024
25 checks passed
@jveski jveski deleted the defaulting-test branch November 6, 2024 17:51
@jveski jveski mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AYM1607 AYM1607 AYM1607 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jveski @AYM1607