Fix composition deletion when a resource is missing namespace #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this comment here to reflect an offline conversation: Currently Eno opaquely passes empty namespaces generated by synthesizers and does not do any defaulting. This change allows the synthesizer to "fix itself" with a new release without being deadlocked, but does not address the defaulting, we might or might not add a feature for this. Created #181 to track this |
AYM1607
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource returned by a synthesizer doesn't have a namespace, getting its current state will fail, which prevents it from being marked as deleted, which blocks composition deletion.