Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two race conditions: one in the test and one in the code.
The main race condition is reached when a composition has been created but not yet synthesized. It will be eligible for rollout, even though that doesn't make sense. We will always reach it on the next pass of the loop anyway.
The test race condition is simpler. It occurs because we use two separate test compositions in the test, and Kubernetes doesn't provide synchronization across resources. The same race isn't an issue in production because we don't care so much about ordering in within the eventually consistent system.