Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synthesis race condition #17

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix synthesis race condition #17

merged 1 commit into from
Dec 11, 2023

Conversation

jveski
Copy link
Collaborator

@jveski jveski commented Dec 11, 2023

Fixes two race conditions: one in the test and one in the code.

The main race condition is reached when a composition has been created but not yet synthesized. It will be eligible for rollout, even though that doesn't make sense. We will always reach it on the next pass of the loop anyway.

The test race condition is simpler. It occurs because we use two separate test compositions in the test, and Kubernetes doesn't provide synchronization across resources. The same race isn't an issue in production because we don't care so much about ordering in within the eventually consistent system.

@jveski
Copy link
Collaborator Author

jveski commented Dec 11, 2023

I'm going to merge this myself because all of the reviewers are out for the holidays. I will continue to leave a coherent PR trail for upcoming changes and we will review retroactively.

@jveski jveski merged commit bfce521 into main Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant