Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manager package and do some housekeeping #11

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Add manager package and do some housekeeping #11

merged 10 commits into from
Nov 17, 2023

Conversation

jveski
Copy link
Collaborator

@jveski jveski commented Nov 13, 2023

  • Manager package constructs a ctrl.Manager for both integration tests and production use, and owns indices since they are manager-scoped (so shouldn't be owned by controllers)
  • Converts PodCreation a pointer because there will be a period of time between allocating the struct and populating the creation timestamp
  • Adds LastRolloutTime to synthesizer status in anticipation of the rollout mechanism
  • Adds a custom log constructor to add controller name to the logs of each controller. This is better than just adding the fields within the Reconcile function because they will also be included when controller-runtime logs errors.
  • Adds k8s version matrix to the integration tests in CI

Copy link
Contributor

@AYM1607 AYM1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some tests need field renaming, other than that, LGTM

@jveski jveski merged commit d106616 into main Nov 17, 2023
2 checks passed
@jveski jveski deleted the mgrpkg branch November 17, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants