Skip to content

Commit

Permalink
Remove old TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
Jordan Olshevski committed Jan 5, 2024
1 parent d53a4fd commit d357654
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions internal/controllers/cleanup/composition.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ import (
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
)

// TODO: Should we limit the max number of resource slices per composition to protect etcd in the face of partial resource slice write failures?

// TODO: Add finalizer on composition to block until all resource slices owned by the composition are fully deleted (reuse builtin?)

type compositionController struct {
client client.Client
}
Expand Down
2 changes: 0 additions & 2 deletions internal/controllers/cleanup/resourceslice.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ import (

// TODO: Should we limit the max number of resource slices per composition to protect etcd in the face of partial resource slice write failures?

// TODO: Add finalizer on composition to block until all resource slices owned by the composition are fully deleted (reuse builtin?)

type resourceSliceController struct {
client client.Client
}
Expand Down

0 comments on commit d357654

Please sign in to comment.