Handle nil cache entries

Azure · Dec 6, 2023 · a7378c3 · a7378c3
1 parent 9e755c9
commit a7378c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/internal/reconstitution/cache.go b/internal/reconstitution/cache.go
@@ -45,6 +45,9 @@ func (c *cache) Get(ctx context.Context, ref *ResourceRef, gen int64) (*Resource
 
 	resKey := resourceKey{Kind: ref.Kind, Namespace: ref.Namespace, Name: ref.Name}
 	res, ok := resources[resKey]
+	if !ok {
+		return nil, false
+	}
 	return &Resource{
 		Ref:               ref,
 		Manifest:          res.Manifest,

diff --git a/internal/reconstitution/reconstituter.go b/internal/reconstitution/reconstituter.go
@@ -16,8 +16,6 @@ import (
 	"github.com/Azure/eno/internal/manager"
 )
 
-// TODO: This is fucked because we don't check both the comp/syn gen - only comp (I think)
-
 // reconstituter reconstitutes individual resources from resource slices.
 // Similar to an informer but with extra logic to handle expanding the slice resources.
 type reconstituter struct {