Skip to content

Commit

Permalink
Remove unused test
Browse files Browse the repository at this point in the history
  • Loading branch information
Jordan Olshevski committed Dec 15, 2023
1 parent 646d56c commit 8e2e2cc
Showing 1 changed file with 0 additions and 49 deletions.
49 changes: 0 additions & 49 deletions internal/controllers/synthesis/exec_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,52 +77,3 @@ func TestExecIntegrationHappyPath(t *testing.T) {
assert.Contains(t, slice.Spec.Resources[0].Manifest, "Composition")
assert.Contains(t, slice.Spec.Resources[0].Manifest, "test-input-name") // sets the input name annotation
}

// TODO
//
// func TestExecIntegrationExit1(t *testing.T) {
// if os.Getenv("RUN_EXEC_INTEGRATION") == "" {
// t.Skipf("skipping pod exec integration test")
// }

// ctx := testutil.NewContext(t)
// mgr, err := manager.New(logr.FromContextOrDiscard(ctx), &manager.Options{
// Rest: ctrl.GetConfigOrDie(),
// })
// require.NoError(t, err)
// cli := mgr.GetClient()

// require.NoError(t, NewPodLifecycleController(mgr, minimalTestConfig))
// require.NoError(t, NewStatusController(mgr))
// require.NoError(t, NewRolloutController(mgr, time.Millisecond*10))
// require.NoError(t, NewExecController(mgr))
// go mgr.Start(ctx)

// syn := &apiv1.Synthesizer{}
// syn.Name = "test-syn"
// syn.Spec.Image = "alpine:latest"
// syn.Spec.Command = []string{"/bin/sh", "-c", "echo 'something went wrong' > /dev/stderr && exit 1"}
// require.NoError(t, cli.Create(ctx, syn))

// comp := &apiv1.Composition{}
// comp.Name = "test-comp"
// comp.Namespace = "default"
// comp.Spec.Synthesizer.Name = syn.Name
// comp.Spec.Inputs = []apiv1.InputRef{{
// Name: "test-input-name",
// Resource: &apiv1.ResourceInputRef{
// // Use self as input since it's easy
// APIVersion: "eno.azure.io/v1",
// Kind: "Composition",
// Namespace: comp.Namespace,
// Name: comp.Name,
// },
// }}
// require.NoError(t, cli.Create(ctx, comp))

// // The pod eventually performs the synthesis
// testutil.SomewhatEventually(t, time.Second*30, func() bool {
// err = cli.Get(ctx, client.ObjectKeyFromObject(comp), comp)
// return err == nil && comp.Status.CurrentState != nil && comp.Status.CurrentState.Synthesized
// })
// }

0 comments on commit 8e2e2cc

Please sign in to comment.