Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Fixing the elevator model #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

troyhopwood
Copy link
Contributor

Description and Motivation

...

Change type

  • Bug fix
  • New feature
  • Enhancement
  • Breaking change (breaks backward compatibility)

Checklist:

  • All tests passed
  • The code follows the code style and conventions of this project
  • The change requires a change to the documentation
  • I have updated the documentation accordingly

The healthy elevator doesn't move. Moving is set to true in the JS, but not set in the JSON so false is winning.
@@ -12,7 +12,8 @@
"vibration": 10.0,
"vibration_unit": "mm",
"temperature": 75.0,
"temperature_unit": "F"
"temperature_unit": "F",
"moving": true
Copy link
Collaborator

@peterfelts peterfelts Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me think that we don't even use/consume the default state in the JS files here and here when state values are provided in the device-model files.

It would be great if this change included a comment in all the JS files that called out that we don't respect these default values if they're provided in the device model (I assume that is why you added the value here).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants