fix(mockapi): dotnet compatibility failure #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archerzz
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft and
tadelesh
as code owners
🦋 Changeset detectedLatest commit: 35058b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
archerzz
commented
Nov 11, 2024
packages/cadl-ranch-specs/http/authentication/api-key/mockapi.ts
Outdated
Show resolved
Hide resolved
archerzz
commented
Nov 11, 2024
packages/cadl-ranch-specs/http/authentication/http/custom/mockapi.ts
Outdated
Show resolved
Hide resolved
archerzz
commented
Nov 11, 2024
dotnet uses different but compatible datetime format, so the comparison should use `coercedBodyEquals`
archerzz
force-pushed
the
fix-donet-compatibility
branch
from
0c99320
to
d4edbea
Compare
weidongxu-microsoft
approved these changes
Nov 11, 2024
archerzz
added a commit
to archerzz/typespec
that referenced
this pull request
Nov 11, 2024
this is a backport of Azure/cadl-ranch#769 dotnet SDK uses a different but compatible datetime format, so we should use `coercedBodyEquals`, instead of exact match.
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
Nov 13, 2024
This is a backport of Azure/cadl-ranch#769 dotnet SDK uses a different but compatible datetime format, so we should use `coercedBodyEquals`, instead of exact match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet uses different but compatible datetime format, so the comparison should use
coercedBodyEqualsCadl Ranch Contribution Checklist:
@scenarionames. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDocs for extra scenario description and to tell people how to pass my mock api check.