Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen Tests ARM, test case for listing available operations #763

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

v-hongli1
Copy link
Member

Cadl Ranch Contribution Checklist:

  • I have written a scenario spec
  • I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.
  • I have written a mock API
  • I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

@XiaofeiCao
Copy link
Contributor

Please ensure generated Java code can pass the test.

Copy link
Contributor

@XiaofeiCao XiaofeiCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this into a new folder.
http/azure/resource-manager/operations:

  • main.tsp
  • available-operations.tsp
  • check-name-availability.tsp

Reason is that these two operations are not tied to any particular resource, rather RP itself.

@v-hongli1
Copy link
Member Author

@XiaofeiCao

Let's put this into a new folder. http/azure/resource-manager/operations:

  • main.tsp
  • available-operations.tsp
  • check-name-availability.tsp

Reason is that these two operations are not tied to any particular resource, rather RP itself.

Is the namespace defined as Azure.ResourceManager.Operations? However, this naming will cause an exception like Duplicate name: "Operations".
image

@XiaofeiCao
Copy link
Contributor

XiaofeiCao commented Oct 30, 2024

Your namespace and interface name collide with each other(they are all called Operations).

I see, there is also a Azure.ResourceManager.Operations interface in arm lib...
We should rename the namespace to something else, candidates:

  1. Azure.ResourceManager.CommonOperations
  2. Azure.ResourceManager.ArmOperations
  3. Azure.ResourceManager.OperationTemplates

In the future, we will also have LRO, pageable, and other operations that need deeper testing.
I would prefer option3, Azure.ResourceManager.OperationTemplates. Chances that we define raw operations for ARM
is pretty low..
@iscai-msft Let me know your thoughts, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants