-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopen Tests ARM, test case for ExtensionResource #761
Open
v-hongli1
wants to merge
4
commits into
Azure:main
Choose a base branch
from
v-hongli1:issues#689_ReOpen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaofeiCao
reviewed
Oct 29, 2024
packages/cadl-ranch-specs/http/azure/resource-manager/resources/extension.tsp
Show resolved
Hide resolved
XiaofeiCao
reviewed
Oct 29, 2024
packages/cadl-ranch-specs/http/azure/resource-manager/resources/mockapi.ts
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Oct 29, 2024
packages/cadl-ranch-specs/http/azure/resource-manager/resources/mockapi.ts
Outdated
Show resolved
Hide resolved
v-hongli1
force-pushed
the
issues#689_ReOpen
branch
from
October 31, 2024 05:51
0b5f192
to
9983e72
Compare
v-hongli1
force-pushed
the
issues#689_ReOpen
branch
from
October 31, 2024 05:55
312a7b6
to
a94977f
Compare
XiaofeiCao
reviewed
Nov 1, 2024
packages/cadl-ranch-specs/http/azure/resource-manager/resources/mockapi.ts
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Nov 1, 2024
packages/cadl-ranch-specs/http/azure/resource-manager/resources/mockapi.ts
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Nov 1, 2024
packages/cadl-ranch-specs/http/azure/resource-manager/resources/extension.tsp
Outdated
Show resolved
Hide resolved
v-hongli1
force-pushed
the
issues#689_ReOpen
branch
2 times, most recently
from
November 1, 2024 07:50
e4d9c1a
to
a94977f
Compare
v-hongli1
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft,
tadelesh and
timotheeguerin
as code owners
November 4, 2024 06:23
XiaofeiCao
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure test pass on Java SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensionResource
#689Cadl Ranch Contribution Checklist:
@scenario
names. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDoc
s for extra scenario description and to tell people how to pass my mock api check.