Unbreak image datasets in model prediction component #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
temporarily deployed
to
Testing
GitHub Actions
Inactive
rdondera-microsoft
requested review from
rjaincc,
ankushbhatia2 and
ShipraJain01
rjaincc
approved these changes
Oct 9, 2024
ShipraJain01
approved these changes
Oct 9, 2024
ankushbhatia2
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image dataset creation code was broken by an update to a
pandasversion withoutdataframe.append(), which creation code called. This PR creates datasets by appending to lists and making dataframes from them. Also included: unit tests.Tested by running unit tests locally and pipelines in the cloud: https://ml.azure.com/experiments/id/3cfa7d04-03b8-4d43-a540-b8d6f93e43b4/runs/strong_plow_cfb11ywv18?wsid=/subscriptions/dbd697c3-ef40-488f-83e6-5ad4dfb78f9b/resourceGroups/rdondera/providers/Microsoft.MachineLearningServices/workspaces/validatr&tid=72f988bf-86f1-41af-91ab-2d7cd011db47# and https://ml.azure.com/experiments/id/9f7237b4-3232-49d3-ae02-e07326242835/runs/mango_skin_kqs2b1l5cl?wsid=/subscriptions/dbd697c3-ef40-488f-83e6-5ad4dfb78f9b/resourceGroups/rdondera/providers/Microsoft.MachineLearningServices/workspaces/benchmarking&tid=72f988bf-86f1-41af-91ab-2d7cd011db47# .
Note: a github workflow for the unit tests will be added in a subsequent PR.