Remove generated REST client which depends on deprecated package. #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For `RestHealthCheckService` (not really used now), the HttpClient timeout is not impacted by user settings. * For `ServiceManager.IsServiceHeathy`, the http client timeout is impacted by user settings. * For AAD related REST API calls, because they uses a static `HttpClientFactory` instance, they have never impacted by the user settings.
vicancy
reviewed
Oct 25, 2023
| } | ||
| retry++; | ||
| } while (needRetry); | ||
| endpoint.Online = isHealthy; |
There was a problem hiding this comment.
what happens when the endpoint count hotreloads to 1 while the last check is Online=false? It does not check again so even if the endpoint is online it does not change back to online?
There was a problem hiding this comment.
Now the checking will continue if it detects any of the endpoint is offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestHealthCheckService(not really used now), the HttpClient timeout is not impacted by user settings.ServiceManager.IsServiceHeathy, the http client timeout is impacted by user settings.HttpClientFactoryinstance, they have never impacted by the user settings.