Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release V1.21.7 #1832

Closed
wants to merge 32 commits into from
Closed

Release V1.21.7 #1832

wants to merge 32 commits into from

Conversation

JialinXin
Copy link
Contributor

Summary of the changes (Less than 80 chars)

  • Detail 1
  • Detail 2

Fixes #bugnumber (in this specific format)

vicancy and others added 30 commits June 28, 2022 15:26
* Update Actions to use dotnet build (Azure#1663)

* Update windows.yml

* Add configurable options (Azure#1654)

* Update CI to enable net7.0 preview builds (Azure#1677)

* Support net7.0

* update osx/ubuntu.

* revert common package upgrade.

* update build-source guide and revert net7.0 in src.

* Add OrTimeout()

* Fix build warnings and add net6 samples (Azure#1676)

* Fix build warning

* Update docs

* Fix build failure

* Fix test failure

* Fix vlunerability issue (Azure#1678)

* Fix vlunerability issue

* fix filters

* fix filters

* Update use-signalr-service.md (Azure#1683)

* Change emulator to net6.0 (Azure#1682)

* Change emulator to net6.0

* Fix test

* Add filter property...... (Azure#1686)

* Add filter

* Add multiPayload case

* Adding comments

* Update management-sdk-guide.md (Azure#1689)

Improve a confusing statement. The original statement can also be interpreted as this SDK only supports SignalR clients based on ASP.NET Core C#, which confuses users. Azure#1688

* Expose InstanceId in ClientConnectionContext (Azure#1692)

* Fix `HubConnectionContext.UserIdentifier` is null when negotiation with Management SDK (Azure#1691)

When clients negotiatie with Management SDK and connect to SignalR server, IUserIdProvider might not work as the user ID is set directly in the Management SDK.

To make HubConnectionContext.UserIdentifier have the valid value in this case, we should set it before the server accesses it. HubLifetimeManager{THub}.OnConnectedAsync(HubConnectionContext) is the only chance we can set the value. However, we cannot access the Constants.ClaimType.UserId as ASRS system claims are trimmed there. HubConnectionContext.Features is the place where we can store the user Id.

The following code is the injection point.
https://github.com/dotnet/aspnetcore/blob/v6.0.9/src/SignalR/server/Core/src/HubConnectionHandler.cs#L132-L141

Fixes Azure#1679

* Add ClientInvocationManager (Azure#1684)

* add ClientInvocationManager

* update CallerClientResultsManager (Azure#1697)

add `TryCompleteResult` for `ErrorCompletionMessage`

* Implement close on client authentication expiration (Azure#1699)

* Add spec for client-invocation. (Azure#1701)

* Add spec for client-invocation.

* minor update direction for ErrorCompletionMessage

* Add client Invocation implementation and UTs (Azure#1687)

* Add client Invocation implementation and UTs

* [ClientInvocation] Fix cleanup in caller case. (Azure#1702)

* Fix cleanup in caller case.

* fix UT.

* Update src/Microsoft.Azure.SignalR.Common/ClientInvocation/IClientInvocationManager.cs

Co-authored-by: Liangying.Wei <[email protected]>

Co-authored-by: Liangying.Wei <[email protected]>

* Add ClientResultSample (Azure#1703)

* Add ClientResultSample

* Move file

* minor update.

* minor update README.

* show server/service ex.message

* Add Broadcast method and update README

* Fix proxy not applied to serverless transient mode (Azure#1708)

Fix Azure#1700

* silent IDE0090 check (Azure#1709)

* reduce retry interval when auth failed (Azure#1451)

* Clean up dependencies. (Azure#1711)

* Update dep to GA version.

* clean up dependencies

* clean management.

* fix test dep.

Co-authored-by: Liangying.Wei <[email protected]>
Co-authored-by: Kevin Guo <[email protected]>
Co-authored-by: yzt <[email protected]>
Co-authored-by: Eric Xing <[email protected]>
Co-authored-by: Terence Fan <[email protected]>
@JialinXin JialinXin marked this pull request as ready for review September 14, 2023 05:53
@JialinXin JialinXin closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants