use named templating in log messages #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
vicancy
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Hi @julienforet, thanks for the contribution! The PR looks great to me. Looks like there is a test failure, could you help address that?
[xUnit.net 00:00:09.11] Microsoft.Azure.SignalR.Tests.MessageLogTests.MessageLogTest [FAIL]
Failed Microsoft.Azure.SignalR.Tests.MessageLogTests.MessageLogTest [12 ms]
Error Message:
System.FormatException : Input string was not in a correct format.
Stack Trace:
at System.Text.ValueStringBuilder.ThrowFormatInvalidString()
at System.Text.ValueStringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
at System.String.Format(String format, Object arg0)
at Microsoft.Azure.SignalR.Tests.MessageLogTests.MessageLogTest() in /Users/runner/work/azure-signalr/azure-signalr/test/Microsoft.Azure.SignalR.Tests/Logging/MessageLogTests.cs:line 22
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
wanlwanl
approved these changes
Jun 26, 2023
|
Sorry for the delay, I fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using log destructuration having logs with {0}, {1} in templates can be an issue as these have different types for each log messages