add threadsafe lock

Azure · Jul 11, 2023 · 9ce2e5b · 9ce2e5b
1 parent 6639876
commit 9ce2e5b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Microsoft.Azure.SignalR.Common/Endpoints/ServiceEndpoint.cs b/src/Microsoft.Azure.SignalR.Common/Endpoints/ServiceEndpoint.cs
@@ -17,7 +17,9 @@ public class ServiceEndpoint
 
  private readonly TokenCredential _tokenCredential;
 
- private AccessKey _accessKey;
+ private readonly object _lock = new object();
+
+ private volatile AccessKey _accessKey;
 
  public string ConnectionString { get; }
 
@@ -80,7 +82,13 @@ internal AccessKey AccessKey
  {
  get
  {
- _accessKey ??= new AadAccessKey(_serviceEndpoint, _tokenCredential, ServerEndpoint);
+ if (_accessKey is null)
+ {
+ lock (_lock)
+ {
+ _accessKey ??= new AadAccessKey(_serviceEndpoint, _tokenCredential, ServerEndpoint);
+ }
+ }
  return _accessKey;
  }
  private init => _accessKey = value;

diff --git a/test/Microsoft.Azure.SignalR.Common.Tests/Auth/AadAccessKeyTests.cs b/test/Microsoft.Azure.SignalR.Common.Tests/Auth/AadAccessKeyTests.cs
@@ -3,7 +3,6 @@
 using System.Security.Claims;
 using System.Threading;
 using System.Threading.Tasks;
-
 using Azure.Identity;
 
 using Xunit;