Add support for KubernetesConfiguration/FluxConfiguration #4275
Conversation
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
| │ ├── AzureBlob: *Object (9 properties) | ||
| │ │ ├── AccountKey: *genruntime.SecretReference | ||
| │ │ ├── ContainerName: *string | ||
| │ │ ├── LocalAuthRef: *string |
There was a problem hiding this comment.
Any idea what this is, and if it's a secret?
There was a problem hiding this comment.
It's the "Name of a local secret on the Kubernetes cluster to use as the authentication secret rather than the managed or user-provided configuration secrets."
| │ ├── GitRepository: *Object (8 properties) | ||
| │ │ ├── HttpsCACert: *genruntime.SecretReference | ||
| │ │ ├── HttpsUser: *string | ||
| │ │ ├── LocalAuthRef: *string |
| │ │ ├── "Bucket" | ||
| │ │ └── "GitRepository" | ||
| │ ├── Suspend: *bool | ||
| │ ├── SystemData: *Object (6 properties) |
There was a problem hiding this comment.
I think that systemdata is expected to be readonly? That's what https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v6/types.json#L31 says at least.
There was a problem hiding this comment.
I think we can just prune this from the spec.
| tc := globalTestContext.ForTest(t) | ||
| rg := tc.CreateTestResourceGroupAndWait() | ||
|
|
||
| adminUsername := "adminUser" |
There was a problem hiding this comment.
Maybe not the most important topic in this PR, so feel free to ignore it or maybe we should file a separate test improvement issue, but I think you can create AKS clusters without SSH access, and just specify managedIdentity intead.
Feels cleaner for these cases where don't actually care about SSH access?
There was a problem hiding this comment.
Sounds like a good idea, although bit torn on if it's worth spending time to get it replaced with MI and re-record the tests?
Since it's just a CRUD test for a resource and we have random generated passwords safe.
There was a problem hiding this comment.
Maybe just file a low-priority issue for it?
v2/samples/kubernetesconfiguration/v1api/v1api20230501_fluxconfiguration.yaml
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Closes #2312
What this PR does / why we need it:
Add new resource Microsoft.KubernetesConfiguration/FluxConfiguration.
If applicable: