This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Support for building Message objects from ArraySegments. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Is this still going to make it? |
|
Any chance this can be picked up in the next minor version? It helps to optimize memory usage for library users and work better with modern code that users ArraySegment to pass around data. |
|
@axisc should this be reviewed internally to decide wherever this PR should be completed and merged or not? Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#404
For consideration by the team...
Implemented building Messages from ArraySegments in a non-API-breaking way.
Admittedly, it is not overly elegant. Not breaking the existing API and keeping it simply was challenging.