-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed builders from eventhubs; removed impl Into<String> from eventhubs and AMQP; Fixed time conversion issue with 1-1-0001 #1892
base: main
Are you sure you want to change the base?
Conversation
…hubs and AMQP; Fixed time conversion issue with 1-1-0001
…strument, contains_key takes a borrowed key, not an owned key
…tured key; Removed several requirements on AmqpOrderedMap K and V
2f72f76
to
2247665
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better - almost there - but a couple outstanding questions and requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some thoughts about symmetrically implementing PartialEq
you could probably avoid.
A lot of churn, basically boiling down to 4 changes, related to recent API guideline changes:
CoPilot summary
This pull request includes several changes to the
sdk/core/azure_core_amqp
module, focusing on improving type consistency and handling optional values. The most important changes involve updating method signatures to use concrete types instead of generics and adding support for an optional token type in authorization methods.Type Consistency Improvements:
AmqpClaimsBasedSecurityApis
,AmqpConnectionApis
,AmqpManagementApis
, andAmqpSenderApis
to use concreteString
types instead of generics likeimpl Into<String>
. (sdk/core/azure_core_amqp/src/cbs.rs
,sdk/core/azure_core_amqp/src/connection.rs
,sdk/core/azure_core_amqp/src/fe2o3/cbs.rs
,sdk/core/azure_core_amqp/src/fe2o3/connection.rs
,sdk/core/azure_core_amqp/src/fe2o3/management.rs
,sdk/core/azure_core_amqp/src/fe2o3/sender.rs
,sdk/core/azure_core_amqp/src/management.rs
) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Optional Token Type Support:
token_type
parameter to theauthorize_path
method inAmqpClaimsBasedSecurityApis
to allow specifying the type of token used for authorization. If not supplied, "jwt" is assumed. (sdk/core/azure_core_amqp/src/cbs.rs
,sdk/core/azure_core_amqp/src/fe2o3/cbs.rs
) [1] [2]Code Simplification:
fe2o3_amqp_types
by using directString
values and handling optional values more explicitly. (sdk/core/azure_core_amqp/src/fe2o3/messaging/message_fields.rs
,sdk/core/azure_core_amqp/src/fe2o3/messaging/message_source.rs
,sdk/core/azure_core_amqp/src/fe2o3/value.rs
) [1] [2] [3] [4] [5] [6] [7] [8] [9]Comment Updates:
sastoken
to the list of spell-checked words. (sdk/core/azure_core_amqp/src/cbs.rs
)These changes collectively enhance the codebase by making it more consistent and easier to understand, while also adding flexibility for handling different token types in authorization scenarios.