address lints from clippy 1.72.0 (#1344)

sdk/core/Cargo.toml

@@ -11,7 +11,7 @@ documentation = "https://docs.rs/azure_core"
 keywords = ["sdk", "azure", "rest", "iot", "cloud"]
 categories = ["api-bindings"]
 edition = "2021"
-rust-version = "1.67.0"
+rust-version = "1.70.0"
 
 [dependencies]
 async-trait = "0.1"

sdk/core/src/error/mod.rs

@@ -390,7 +390,11 @@ mod tests {
     use super::*;
     use std::io;
 
-    #[allow(dead_code, unconditional_recursion)]
+    #[allow(
+        dead_code,
+        unconditional_recursion,
+        clippy::extra_unused_type_parameters
+    )]
     fn ensure_send<T: Send>() {
         ensure_send::<Error>();
     }

sdk/core/src/http_client/noop.rs

@@ -9,6 +9,7 @@ pub struct NoopClient;
 #[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
 #[cfg_attr(not(target_arch = "wasm32"), async_trait)]
 impl crate::HttpClient for NoopClient {
+    #[allow(clippy::diverging_sub_expression)]
     async fn execute_request(&self, request: &crate::Request) -> crate::Result<crate::Response> {
         panic!(
             "A request was called on the default http client `NoopClient`.\

sdk/storage_blobs/examples/connection_string.rs

@@ -60,7 +60,7 @@ async fn main() -> azure_core::Result<()> {
         let len = value?.blobs.blobs().count();
         println!("received {len} blobs");
         match cnt {
-            0 | 1 | 2 => assert_eq!(len, 3),
+            0..=2 => assert_eq!(len, 3),
             3 => assert_eq!(len, 1),
             _ => panic!("more than 10 entries??"),
         }

sdk/storage_blobs/examples/list_blobs_00.rs

@@ -79,7 +79,7 @@ async fn main() -> azure_core::Result<()> {
         let len = value?.blobs.blobs().count();
         println!("received {len} blobs");
         match cnt {
-            0 | 1 | 2 => assert_eq!(len, 3),
+            0..=2 => assert_eq!(len, 3),
             3 => assert_eq!(len, 1),
             _ => panic!("more than 10 entries??"),
         }

sdk/storage_blobs/examples/list_blobs_01.rs

@@ -157,7 +157,7 @@ async fn main() -> azure_core::Result<()> {
         println!("\treceived {len} blobs");
         match cnt {
             // we added 21 blobs so 5x4 + 1
-            0 | 1 | 2 | 3 => assert_eq!(len, 5),
+            0..=3 => assert_eq!(len, 5),
             4 => assert_eq!(len, 1),
             _ => panic!("more than entries than expected!"),
         }

sdk/storage_blobs/tests/blob.rs

@@ -418,7 +418,7 @@ async fn put_block_blob_and_get_properties() -> azure_core::Result<()> {
 
     assert_eq!(blob_properties.blob.properties.content_length, 6);
 
-    let _ = requires_send_future(blob.get_properties().into_future());
+    requires_send_future(blob.get_properties().into_future()).await?;
     container.delete().await?;
     Ok(())
 }
@@ -550,7 +550,7 @@ async fn set_blobtier() {
     println!("container {} deleted!", container_name);
 }
 
-#[allow(dead_code)]
+#[allow(dead_code, clippy::let_underscore_future)]
 fn send_check() {
     let client = initialize();
     let blob = client.container_client("a").blob_client("b");

sdk/storage_blobs/tests/stream_list_blobs.rs

@@ -60,7 +60,7 @@ async fn stream_list_blobs() {
         let len = value.unwrap().blobs.blobs().count();
         println!("received {} blobs", len);
         match cnt {
-            0 | 1 | 2 => assert_eq!(len, 3),
+            0..=2 => assert_eq!(len, 3),
             3 => assert_eq!(len, 1),
             _ => panic!("more than 10 entries??"),
         }

sdk/storage_datalake/src/clients/directory_client.rs

@@ -15,7 +15,7 @@ pub struct DirectoryClient {
 impl PathClient for DirectoryClient {
     fn url(&self) -> azure_core::Result<Url> {
         let fs_url = self.file_system_client.url()?;
-        let dir_path = vec![fs_url.path(), &self.dir_path].join("/");
+        let dir_path = [fs_url.path(), &self.dir_path].join("/");
         Ok(self.file_system_client.url()?.join(&dir_path)?)
     }
 
@@ -39,7 +39,7 @@ impl DirectoryClient {
     pub fn list_paths(&self) -> ListPathsBuilder {
         let fs_url = self.file_system_client.url().unwrap();
         // the path will contain a leading '/' as we extract if from the path component of the url
-        let dir_path = vec![fs_url.path(), &self.dir_path].join("/");
+        let dir_path = [fs_url.path(), &self.dir_path].join("/");
         ListPathsBuilder::new(self.file_system_client.clone())
             .directory(dir_path)
             .recursive(true)
@@ -63,7 +63,7 @@ impl DirectoryClient {
             .get_directory_client(destination_path);
         let fs_url = self.file_system_client.url().unwrap();
         // the path will contain a leading '/' as we extract if from the path component of the url
-        let dir_path = vec![fs_url.path(), &self.dir_path].join("/");
+        let dir_path = [fs_url.path(), &self.dir_path].join("/");
         RenamePathBuilder::new(destination_client)
             .mode(PathRenameMode::Legacy)
             .rename_source(dir_path)

sdk/storage_datalake/src/clients/file_client.rs

@@ -15,7 +15,7 @@ pub struct FileClient {
 impl PathClient for FileClient {
     fn url(&self) -> azure_core::Result<Url> {
         let fs_url = self.file_system_client.url()?;
-        let file_path = vec![fs_url.path(), &self.file_path].join("/");
+        let file_path = [fs_url.path(), &self.file_path].join("/");
         Ok(self.file_system_client.url()?.join(&file_path)?)
     }
 
@@ -69,7 +69,7 @@ impl FileClient {
         let destination_client = self.file_system_client.get_file_client(destination_path);
         let fs_url = self.file_system_client.url().unwrap();
         // the path will contain a leading '/' as we extract if from the path component of the url
-        let file_path = vec![fs_url.path(), &self.file_path].join("/");
+        let file_path = [fs_url.path(), &self.file_path].join("/");
         RenamePathBuilder::new(destination_client)
             .mode(PathRenameMode::Legacy)
             .rename_source(file_path)

services/autorust/Cargo.toml

@@ -4,3 +4,5 @@ members = [
   "openapi",
   "azure-autorust",
 ]
+
+resolver = "2"

services/autorust/codegen/src/crates.rs

@@ -24,7 +24,7 @@ fn list_dirs_in(dir: impl AsRef<Utf8Path>) -> Result<Vec<Utf8PathBuf>> {
 
 pub fn list_dirs() -> Result<Vec<Utf8PathBuf>> {
     let mut names: Vec<_> = list_dirs_in("../mgmt")?.into_iter().collect();
-    names.extend(list_dirs_in("../svc")?.into_iter());
+    names.extend(list_dirs_in("../svc")?);
     names.sort();
     Ok(names)
 }