Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Fix for invalid x-ms-expiry-time header in request #38524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Storage] Fix for invalid x-ms-expiry-time header in request #38524

wants to merge 1 commit into from

Conversation

prejs
Copy link

@prejs prejs commented Nov 13, 2024 •
edited
Loading

Description

This pull request addresses the issue (#38518) with the DataLakeFileClient.set_file_expiry() method when using expiry_options="NeverExpire". Previously, the method failed due to an incorrect format in the HTTP headers, specifically the redundant x-ms-expiry-time header.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 13, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @prejs! We will review the pull request and get back to you soon.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Nov 13, 2024
@prejs
Copy link
Author

prejs commented Nov 13, 2024

@microsoft-github-policy-service agree

@prejs prejs changed the title [Storage] Fix for invalid x-ms-expiry-time header in request (#38518) [Storage] Fix for invalid x-ms-expiry-time header in request Nov 13, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

@weirongw23-msft weirongw23-msft Awaiting requested review from weirongw23-msft weirongw23-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prejs @azure-sdk