Skip to content

Commit

Permalink
Add lock file for generate-doc tool (#31789)
Browse files Browse the repository at this point in the history
A recent package update broke the tool so we are adding a lock file to
ensure we have a reliable execution.

For details the newer version of
https://www.npmjs.com/package/shiki?activeTab=versions version 1.23.0
introduced a new dependency in shikijs/shiki#832
which no longer compiles.

```
node_modules/oniguruma-to-es/types/parse.d.ts(61,49): error TS2339: Property 'orphan' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,31): error TS2339: Property 'atomic' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,39): error TS2339: Property 'flags' does not exist on type '{}'.
```

Until we figure out what the best way to fix those issues we are pinning
to the older version using a lock file.
  • Loading branch information
weshaggard authored Nov 15, 2024
1 parent 7d256c7 commit a24a372
Show file tree
Hide file tree
Showing 2 changed files with 863 additions and 1 deletion.
2 changes: 1 addition & 1 deletion eng/pipelines/templates/steps/generate-doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ parameters:

steps:
- script: |
npm install
npm ci
workingDirectory: $(System.DefaultWorkingDirectory)/eng/tools/generate-doc
displayName: "Install tool dependencies"
Expand Down
Loading

0 comments on commit a24a372

Please sign in to comment.