Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[function app dedicated github deploy] - update API versions and add … #13082

Closed

Conversation

mumian
Copy link
Collaborator

@mumian mumian commented Jan 3, 2023

…Bicep

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@mumian mumian closed this Jan 10, 2023
@mumian mumian reopened this Jan 10, 2023
@mumian
Copy link
Collaborator Author

mumian commented Feb 21, 2023

@seesharprun - did you create this template? https://github.com/AzureBytes/functionshttpecho.git is not a public repo.

@seesharprun
Copy link
Contributor

I worked on this template years ago back when that repository existed. It no longer exists.

For this template, you can change RepoURL to be a parameter without a default value. Here's an example: https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.web/function-app-dedicated-github-deploy/azuredeploy.json#L44-L50

@mumian
Copy link
Collaborator Author

mumian commented Jul 21, 2023

@seesharprun - without the default value, I will need to specify a value in the parameters file - https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.web/function-app-dedicated-github-deploy/azuredeploy.parameters.json. The template pipeline needs a value to test the deployment before the PR can be merged.

@mumian
Copy link
Collaborator Author

mumian commented Apr 12, 2024

New PR - #13971

@mumian mumian closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants