Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: Dist directory for NPM packaging #84

Merged
merged 2 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@
"name": "azure-kusto-trender",
"main": "dist/kustotrender.js",
"description": "",
"version": "0.0.18",
"version": "0.0.19",
"types": "dist/kustotrender.d.ts",
"repository": {
"type": "git",
"url": "https://github.com/Azure/azure-kusto-trender"
},
"files": [
"dist"
],
"scripts": {
"start": "webpack-dev-server --config webpack.dev.js",
"build": "npm run clean && npm run rollup && npm run webpack && npm run post-build",
Expand Down
4 changes: 2 additions & 2 deletions src/UXClient/Components/Grid/Grid.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class Grid extends Component {
}
}

public renderFromAggregates(data: any, options: any, aggregateExpressionOptions: any, chartComponentData) {
public renderFromAggregates(data: any, options?: any, aggregateExpressionOptions?: any, chartComponentData? : any) {
this.chartOptions.setOptions(options);
var dataAsJson = data.reduce((p,c,i) => {
var aeName = Object.keys(c)[0];
Expand Down Expand Up @@ -237,7 +237,7 @@ class Grid extends Component {
rowsEntered.exit().remove();
}

public render(data: any, options: any, aggregateExpressionOptions: any, chartComponentData: ChartComponentData = null) {
public render(data: any, options?: any, aggregateExpressionOptions?: any, chartComponentData: ChartComponentData = null) {
data = Utils.standardizeTSStrings(data);
this.chartOptions.setOptions(options);
this.gridComponent = d3.select(this.renderTarget);
Expand Down
2 changes: 1 addition & 1 deletion src/UXClient/Components/Heatmap/Heatmap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class Heatmap extends TemporalXAxisComponent {
heatmapCanvas.render(this.chartComponentData, this.chartOptions, hoveredAggKey, null, null, null, null, this.visibleAggs.length === 1);
}

public render (data: any, chartOptions: any, aggregateExpressionOptions?: any) {
public render (data: any, chartOptions?: any, aggregateExpressionOptions?: any) {
super.render(data, chartOptions, aggregateExpressionOptions);
// override visibleSplitByCap
this.aggregateExpressionOptions = this.aggregateExpressionOptions.map((aE: AggregateExpression) => {
Expand Down
2 changes: 1 addition & 1 deletion src/UXClient/Components/Hierarchy/Hierarchy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Hierarchy extends Component {
super(renderTarget);
}

public render(data: any, options: any){
public render(data: any, options?: any){
var self = this;
var targetElement = d3.select(this.renderTarget).classed('tsi-hierarchy', true);
targetElement.html('');
Expand Down
2 changes: 1 addition & 1 deletion src/UXClient/Components/LineChart/LineChart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,7 @@ class LineChart extends TemporalXAxisComponent {
};
}

public render (data: any, options: any, aggregateExpressionOptions?: any) {
public render (data: any, options?: any, aggregateExpressionOptions?: any) {
super.render(data, options, aggregateExpressionOptions);

this.originalSwimLanes = this.aggregateExpressionOptions.map((aEO) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class ModelAutocomplete extends Component {
this.delegate = delegate;
}

public render(chartOptions: any) {
public render(chartOptions?: any) {
this.chartOptions.setOptions(chartOptions);
let targetElement = d3.select(this.renderTarget);
targetElement.html("");
Expand Down
2 changes: 1 addition & 1 deletion src/UXClient/Components/ModelSearch/ModelSearch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class ModelSearch extends Component {

ModelSearch() {}

public async render(hierarchyData: any, chartOptions: any) {
public async render(hierarchyData: any, chartOptions?: any) {
this.chartOptions.setOptions(chartOptions);
let self = this;
let continuationToken, searchText;
Expand Down
Loading