Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service bus batch tests #1414

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

gavin-aguiar
Copy link
Contributor

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@@ -45,6 +45,21 @@ def get_script_dir(cls):
return testutils.E2E_TESTS_FOLDER / 'servicebus_functions' / \
'servicebus_functions_stein'

@testutils.retryable_test(3, 5)
def test_servicebus_batch(self):
data = '{"value": "2024-01-19T12:50:41.250940Z"}'
Copy link
Contributor Author

@gavin-aguiar gavin-aguiar Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail because of a bug where timestamp 2024-01-19T12:50:41.250940Z is parsed as 2024-01-19T12:50:41.25094Z

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eef7628) 85.87% compared to head (6c7960b) 85.46%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1414      +/-   ##
==========================================
- Coverage   85.87%   85.46%   -0.41%     
==========================================
  Files          35       35              
  Lines        1968     1968              
  Branches      370      370              
==========================================
- Hits         1690     1682       -8     
- Misses        209      213       +4     
- Partials       69       73       +4     
Flag Coverage Δ
unittests 85.41% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YunchuWang YunchuWang force-pushed the dev branch 2 times, most recently from 4556193 to b7fbdca Compare March 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant