Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependency logging filtering v2 #1167

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Jan 24, 2023

Introducing a new flag named PYTHON_ENABLE_DEPENDENCY_LOG_FILTERING_MODULES which customers can use to specify list of function app modules(like function_app, or blueprint modules) to receive logs from. The feature is only supported in python new programming model. Logs for any modules(like third party libraries) not listed in the setting will not be logged and captured. If this setting is not configured, all user function app/modules logs will be captured.

Description

Fixes #743


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Introducing a new flag named PYTHON_ENABLE_DEPENDENCY_LOG_FILTERING_MODULES which customers can specify list of function app modules(like function_app, or blueprint modules) to receive logs from. The feature is only supported in python new programming model. Any modules(like third party libraries logs)'s logs will not be logged and captured.
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1167 (1b8d87f) into dev (1c577b0) will decrease coverage by 0.67%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##              dev    #1167      +/-   ##
==========================================
- Coverage   83.87%   83.20%   -0.67%     
==========================================
  Files          34       34              
  Lines        1885     1882       -3     
  Branches      362      277      -85     
==========================================
- Hits         1581     1566      -15     
- Misses        233      243      +10     
- Partials       71       73       +2     
Flag Coverage Δ
unittests 83.20% <45.45%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/logging.py 41.37% <20.00%> (-5.80%) ⬇️
azure_functions_worker/dispatcher.py 87.33% <60.00%> (-1.53%) ⬇️
azure_functions_worker/constants.py 100.00% <100.00%> (ø)
azure_functions_worker/extension.py 99.06% <0.00%> (-0.02%) ⬇️
...ed_memory_data_transfer/shared_memory_constants.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] support for filtering logs
2 participants