Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current glob function is unusably slow when used with a path like
datasetname/parquet/brandcode=*/application=*/year=2022/month=02/day=14/hour=05/*
which in our case should only return a list of each file per brandcode & application (both manageably short lists), but instead does a walk over each year, month, day, and hour before filtering. The new function filters on each step instead.This checklist is used to make sure that common guidelines for a pull request are followed.
Description of the change
General Guidelines