Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fsagnosticglob function #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

JoranDox
Copy link

The current glob function is unusably slow when used with a path like datasetname/parquet/brandcode=*/application=*/year=2022/month=02/day=14/hour=05/* which in our case should only return a list of each file per brandcode & application (both manageably short lists), but instead does a walk over each year, month, day, and hour before filtering. The new function filters on each step instead.


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

The current glob function is unusably slow when used with a path like `datasetname/parquet/brandcode=*/application=*/year=2022/month=02/day=14/hour=05/*` which in our case should only return a list of each file per brandcode & application (both manageably short lists), but instead does a walk over each year, month, day, and hour before filtering. The new function filters on each step instead.
@ghost
Copy link

ghost commented Feb 17, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ JoranDox sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant