Make tests self-contained (#17)

remove data dependencies
Azure · Nov 23, 2022 · 8e838a6 · 8e838a6
1 parent be23936
commit 8e838a6
Show file tree

Hide file tree

Showing 312 changed files with 3,279 additions and 1,424 deletions.
diff --git a/.github/workflows/aks-cluster.yml b/.github/workflows/aks-cluster.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m 
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/analysis-services-server.yml b/.github/workflows/analysis-services-server.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/application-insights.yml b/.github/workflows/application-insights.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m 
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/bastion-host.yml b/.github/workflows/bastion-host.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v -timeout 30m
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/cognitive-search.yml b/.github/workflows/cognitive-search.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v -timeout 30m
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/cognitive-services.yml b/.github/workflows/cognitive-services.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/container-registry.yml b/.github/workflows/container-registry.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/cosmosdb-account.yml b/.github/workflows/cosmosdb-account.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v -timeout 30m
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/data-factory.yml b/.github/workflows/data-factory.yml
@@ -73,6 +73,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/event-hubs-namespace.yml b/.github/workflows/event-hubs-namespace.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/key-vault.yml b/.github/workflows/key-vault.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/machine-learning-compute-instance.yml b/.github/workflows/machine-learning-compute-instance.yml
@@ -71,6 +71,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/machine-learning-synapse-spark.yml b/.github/workflows/machine-learning-synapse-spark.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m 
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/machine-learning-workspace.yml b/.github/workflows/machine-learning-workspace.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/mariadb-database.yml b/.github/workflows/mariadb-database.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/mysql-database.yml b/.github/workflows/mysql-database.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/network-security-group.yml b/.github/workflows/network-security-group.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/network-security-rule.yml b/.github/workflows/network-security-rule.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/postgresql-database.yml b/.github/workflows/postgresql-database.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/private-dns-zone.yml b/.github/workflows/private-dns-zone.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/resource-group.yml b/.github/workflows/resource-group.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/route-table.yml b/.github/workflows/route-table.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/route.yml b/.github/workflows/route.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/sql-database-server.yml b/.github/workflows/sql-database-server.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/sql-database.yml b/.github/workflows/sql-database.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/storage-account.yml b/.github/workflows/storage-account.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/subnet-network-security-group-association.yml b/.github/workflows/subnet-network-security-group-association.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/subnet-route-table-association.yml b/.github/workflows/subnet-route-table-association.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/subnet.yml b/.github/workflows/subnet.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m 
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/synapse-private-link-hub.yml b/.github/workflows/synapse-private-link-hub.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/synapse-spark-pool.yml b/.github/workflows/synapse-spark-pool.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/synapse-sql-pool.yml b/.github/workflows/synapse-sql-pool.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v -timeout 30m
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/user-assigned-identity.yml b/.github/workflows/user-assigned-identity.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/virtual-machine.yml b/.github/workflows/virtual-machine.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/.github/workflows/virtual-network.yml b/.github/workflows/virtual-network.yml
@@ -72,6 +72,6 @@ jobs:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
 
     - name: Unit-test
-      run: go test -v 
+      run: go test -v -timeout 45m
       env:
         GOPATH: "/home/runner/work/azure-labs-modules/azure-labs-modules/${{ env.terraform_workingdir }}"
diff --git a/terraform/aks-cluster/main.tf b/terraform/aks-cluster/main.tf
@@ -70,5 +70,4 @@ resource "azurerm_kubernetes_cluster" "adl_aks" {
 
   api_server_authorized_ip_ranges   = var.api_server_authorized_ip_ranges
   role_based_access_control_enabled = var.role_based_access_control_enabled
-
-}
+}
diff --git a/terraform/aks-cluster/test/aks.tf b/terraform/aks-cluster/test/aks.tf
@@ -2,7 +2,7 @@ module "aks" {
   source = "../"
 
   basename   = random_string.postfix.result
-  rg_name    = var.rg_name
+  rg_name    = module.local_rg.name
   location   = var.location
   dns_prefix = "azdatalbsaks"
 
@@ -13,4 +13,15 @@ module "aks" {
   }
 
   tags = {}
+}
+
+# Module dependencies
+
+module "local_rg" {
+  source = "../../resource-group"
+
+  basename = random_string.postfix.result
+  location = var.location
+
+  tags = local.tags
 }
diff --git a/terraform/aks-cluster/test/locals.tf b/terraform/aks-cluster/test/locals.tf
@@ -0,0 +1,7 @@
+locals {
+  tags = {
+    Project = "Azure/azure-data-labs-modules"
+    Module  = "aks-cluster"
+    Toolkit = "Terraform"
+  }
+}
diff --git a/terraform/aks-cluster/test/outputs.tf b/terraform/aks-cluster/test/outputs.tf
@@ -7,7 +7,6 @@ output "name" {
   value = module.aks.name
 }
 
-
 output "all" {
   value     = module.aks.all
   sensitive = true

diff --git a/terraform/aks-cluster/test/main.tf → terraform/aks-cluster/test/providers.tf b/terraform/aks-cluster/test/main.tf → terraform/aks-cluster/test/providers.tf
@@ -9,7 +9,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "= 3.31.0"
+      version = "= 3.32.0"
     }
   }
 

diff --git a/terraform/aks-cluster/test/unit_test.go b/terraform/aks-cluster/test/unit_test.go
@@ -31,5 +31,4 @@ func TestModule(t *testing.T) {
 	assert.NotNil(name)
 	all := terraform.Output(t, terraformOptions, "all")
 	assert.NotNil(all)
-
 }
diff --git a/terraform/aks-cluster/test/variables.tf b/terraform/aks-cluster/test/variables.tf
@@ -7,9 +7,4 @@ resource "random_string" "postfix" {
 variable "location" {
   type    = string
   default = "North Europe"
-}
-
-variable "rg_name" {
-  type    = string
-  default = "rg-adl-modules-test-01"
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,5 +70,4 @@ resource "azurerm_kubernetes_cluster" "adl_aks" { @@
       api_server_authorized_ip_ranges   = var.api_server_authorized_ip_ranges
       role_based_access_control_enabled = var.role_based_access_control_enabled
-    }
+    }