Query: Fixes (workaround) for query plan issue where placeholder index does not start at zero #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neildsh
requested review from
khdang,
sboshra,
adityasa,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
adityasa
reviewed
Nov 13, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Show resolved
Hide resolved
sc978345
approved these changes
Nov 13, 2024
kundadebdatta
changed the title
kundadebdatta
approved these changes
Nov 13, 2024
kundadebdatta
changed the title
microsoft-github-policy-service
bot
deleted the
users/ndeshpan/placeholderIndexWorkaround
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During query plan generation, we were using the loop index index over order by expressions as the index for placeholders within component queries. However, VectorDistance expressions do not require placeholders. As a result the output placeholder indexes may not always start at 0. The fix for this is currently in PR on the gateway.
We are putting this workaround in the SDK until the gateway fix is deployed.
Type of change