Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to go1.22.7 #3040

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Upgrade to go1.22.7 #3040

merged 9 commits into from
Oct 2, 2024

Conversation

aggarwal0009
Copy link
Contributor

@aggarwal0009 aggarwal0009 commented Oct 1, 2024 •
edited
Loading

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@aggarwal0009 aggarwal0009 requested a review from a team as a code owner October 1, 2024 16:58
@aggarwal0009 aggarwal0009 requested a review from a team as a code owner October 1, 2024 17:33
@aggarwal0009 aggarwal0009 requested review from a team as code owners October 1, 2024 18:33
@aggarwal0009 aggarwal0009 changed the title [WIP]: Upgrade to go v1.22.7 [CVE fix]: Upgrade ACN 1.5.x to go v1.22.7 Oct 1, 2024
@aggarwal0009
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009
Copy link
Contributor Author

/azp run NPM Conformance Tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009
Copy link
Contributor Author

/azp run NPM Scale Test

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr changed the title [CVE fix]: Upgrade ACN 1.5.x to go v1.22.7 Upgrade ACN 1.5.x to go v1.22.7 Oct 1, 2024
@rbtr rbtr changed the title Upgrade ACN 1.5.x to go v1.22.7 Upgrade to go1.22.7 Oct 1, 2024
rbtr
rbtr requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not going to leave the same comment on every line but it needs to be fixed everywhere

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
huntergregory
huntergregory previously requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after a green NPM conformance test run

@huntergregory
Copy link
Contributor

/azp list

@azure-pipelines Azure Pipelines
Copy link

CI/CD Pipelines for this repository:

@huntergregory
Copy link
Contributor

/azp run NPM Conformance Tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009
Copy link
Contributor Author

i'm not going to leave the same comment on every line but it needs to be fixed everywhere

I thought the CVE fixes are in go v1.22.7. cc @miguelgoms for clarification

@rbtr
Copy link
Contributor

rbtr commented Oct 1, 2024

i'm not going to leave the same comment on every line but it needs to be fixed everywhere

I thought the CVE fixes are in go v1.22.7. cc @miguelgoms for clarification

@aggarwal0009 that's correct. by specifying ONLY 1.22, you will get the latest patch of 1.22.x which is currently 1.22.8.
The only place we need to explicitly say "minimum of 1.22.7" (and should actually say 1.22.8, since that is the latest release), is in the go.mod

@aggarwal0009
Copy link
Contributor Author

i'm not going to leave the same comment on every line but it needs to be fixed everywhere

I thought the CVE fixes are in go v1.22.7. cc @miguelgoms for clarification

@aggarwal0009 that's correct. by specifying ONLY 1.22, you will get the latest patch of 1.22.x which is currently 1.22.8. The only place we need to explicitly say "minimum of 1.22.7" (and should actually say 1.22.8, since that is the latest release), is in the go.mod

Updated.

@aggarwal0009
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009
Copy link
Contributor Author

/azp run NPM Scale Test

@aggarwal0009
Copy link
Contributor Author

/azp run NPM Conformance Tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr enabled auto-merge October 2, 2024 01:10
@rbtr rbtr dismissed huntergregory’s stale review October 2, 2024 01:10

unblocking - passed NPM conformance

@rbtr rbtr added this pull request to the merge queue Oct 2, 2024
Merged via the queue into release/v1.5 with commit 0ab889c Oct 2, 2024
27 checks passed
@rbtr rbtr deleted the ankaggar/upgrade_go_1_23 branch October 2, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbtr rbtr rbtr approved these changes

@vakalapa vakalapa vakalapa approved these changes

@isaac-dasan isaac-dasan isaac-dasan approved these changes

@paulyufan2 paulyufan2 paulyufan2 approved these changes

@ritwikranjan ritwikranjan Awaiting requested review from ritwikranjan ritwikranjan is a code owner automatically assigned from Azure/azure-sdn-members

@ZetaoZhuang ZetaoZhuang Awaiting requested review from ZetaoZhuang ZetaoZhuang is a code owner

@camrynl camrynl Awaiting requested review from camrynl camrynl is a code owner

@ashvindeodhar ashvindeodhar Awaiting requested review from ashvindeodhar ashvindeodhar is a code owner

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner

@huntergregory huntergregory Awaiting requested review from huntergregory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aggarwal0009 @huntergregory @rbtr @vakalapa @isaac-dasan @paulyufan2