Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade go toolchain to 1.23 #3022

Merged
merged 2 commits into from
Oct 10, 2024
Merged

chore: upgrade go toolchain to 1.23 #3022

merged 2 commits into from
Oct 10, 2024

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Sep 19, 2024

Reason for Change:

Updates the Go version to v1.23.1 for various improvements, fixes to stdlib, and toolchain upgrades.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr enabled auto-merge September 19, 2024 18:27
@rbtr rbtr self-assigned this Sep 19, 2024
@rbtr rbtr added cns Related to CNS. npm Related to NPM. cni Related to CNI. ci Infra or tooling. go Pull requests that update Go code release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains dropgz dropgz labels Sep 19, 2024
@rbtr
Copy link
Contributor Author

rbtr commented Sep 19, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jpayne3506
jpayne3506 previously approved these changes Sep 19, 2024
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is not a priority. We may want to look at leveraging the toolchain directive to have reproduceable builds for each of our releases/tags.

go.mod Outdated Show resolved Hide resolved
@jpayne3506
Copy link
Contributor

Going to need to re-run the workflows with an updated ruleset for this to merge.

go.mod Show resolved Hide resolved
.github/workflows/crdgen.yaml Show resolved Hide resolved
@rbtr rbtr force-pushed the chore/go1.23 branch 2 times, most recently from a13abcd to 07353b1 Compare October 9, 2024 16:49
@rbtr
Copy link
Contributor Author

rbtr commented Oct 9, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Evan Baker <[email protected]>
@rbtr
Copy link
Contributor Author

rbtr commented Oct 9, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

aggarwal0009
aggarwal0009 previously approved these changes Oct 9, 2024
@rbtr
Copy link
Contributor Author

rbtr commented Oct 9, 2024

/azp run NPM Conformance Tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

paulyufan2
paulyufan2 previously approved these changes Oct 9, 2024
huntergregory
huntergregory previously approved these changes Oct 9, 2024
jpayne3506
jpayne3506 previously approved these changes Oct 9, 2024
camrynl
camrynl previously approved these changes Oct 9, 2024
@rbtr rbtr disabled auto-merge October 9, 2024 19:52
ZetaoZhuang
ZetaoZhuang previously approved these changes Oct 9, 2024
@rbtr rbtr added this pull request to the merge queue Oct 9, 2024
@rbtr rbtr removed this pull request from the merge queue due to a manual request Oct 9, 2024
@rbtr
Copy link
Contributor Author

rbtr commented Oct 10, 2024

this passed all pipeline checks and previously had full approvals, so i'm going to merge it

@rbtr rbtr merged commit dbdb22d into master Oct 10, 2024
98 checks passed
@rbtr rbtr deleted the chore/go1.23 branch October 10, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. cni Related to CNI. cns Related to CNS. dropgz dropgz go Pull requests that update Go code needs-backport Change needs to be backported to previous release trains npm Related to NPM. release/latest Change affects latest release train
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants