{AKS} [KMS]: Remove private keyvault kms tests #29965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzhecheng
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
lzhecheng
force-pushed
the
kms-test-vnet-integration
branch
from
d744728
to
7167515
Compare
lzhecheng
changed the title
--enableVnetIntegration=true
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29965 in repo Azure/azure-cli |
lzhecheng
force-pushed
the
kms-test-vnet-integration
branch
from
7167515
to
4dd25a1
Compare
|
AKS |
FumingZhang
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_create_with_azurekeyvaultkms_private_key_vault
- test_aks_update_with_azurekeyvaultkms_private_key_vault
- test_aks_create_with_azurekeyvaultkms_private_cluster_v1_private_key_vault
|
I would say this is not a breaking change to user as you've only modified tests. Also, the changes are invisible to users, you could change the beginning of the PR title to {AKS} (won't leave a note in the release history). |
lzhecheng
force-pushed
the
kms-test-vnet-integration
branch
from
4dd25a1
to
4d8a7c1
Compare
lzhecheng
changed the title
--enableVnetIntegration=true--enableVnetIntegration=true
lzhecheng
changed the title
--enableVnetIntegration=true--enableVnetIntegration=true
Thank you! Updated. |
FumingZhang
reviewed
Sep 26, 2024
| '--assign-identity {identity_id} ' \ | ||
| '--enable-azure-keyvault-kms --azure-keyvault-kms-key-id={key_id} ' \ | ||
| '--azure-keyvault-kms-key-vault-network-access=Private --azure-keyvault-kms-key-vault-resource-id {kv_resource_id} ' \ | ||
| '--enable-apiserver-vnet-integration=true ' \ |
There was a problem hiding this comment.
This is an action option and does not accept a value.
lzhecheng
force-pushed
the
kms-test-vnet-integration
branch
from
4d8a7c1
to
b9b7443
Compare
private keyvault + konnectivity is blocked now, so vnet integration should be used. Signed-off-by: Zhecheng Li <[email protected]>
lzhecheng
force-pushed
the
kms-test-vnet-integration
branch
from
b9b7443
to
ea96ee8
Compare
lzhecheng
changed the title
--enableVnetIntegration=true
|
@zhoxing-ms @yanzhudd Could you please merge this one? Thanks. |
|
May I ask why do you need to remove this test? |
The test case is no longer a valid scenario. To use private key vault with KMS enabled, user need to enable the preview feature vnet integration for the cluster. Since it is a preview feature, the official azure-cli does not support it yet. Therefore, the relevant test cases are retained in cli-extensions/aks-preview after being appropriately modified, but have been deleted here. |
zhoxing-ms
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create/update --enable-azure-keyvault-kms
Description
[KMS] Update tests. private keyvault + konnectivity is blocked now, so vnet integration should be used
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.