{Resource} Remove direct call to msrestazure
#29959
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
️✔️AzureCLI-BreakingChangeTest
|
|
Resource |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms and
yonzhan
microsoft-github-policy-service
bot
added
the
ARM
|
Could you please help migrate the usage of |
Jing-song
requested review from
jiasli,
evelyn-ys,
kairu-ms,
calvinhzy,
necusjz,
bebound and
wangzelin007
as code owners
Done |
zhoxing-ms
reviewed
Sep 27, 2024
Comment on lines
4573
to
4576
| def get_long_running_status(status_link, headers=None): | ||
| request = client.get(status_link, query_parameters, header_parameters) | ||
| if headers: | ||
| request.headers.update(headers) | ||
| pipeline_response = client._pipeline.run(request, stream=False) | ||
| return pipeline_response.http_response.internal_response | ||
|
|
||
| def get_long_running_output(response): | ||
| from azure.core.exceptions import HttpResponseError | ||
| if response.status_code not in [200, 202, 204]: | ||
| exp = HttpResponseError(response) | ||
| exp.request_id = response.headers.get('x-ms-request-id') | ||
| raise exp | ||
| return response.text | ||
|
|
||
| return AzureOperationPoller(long_running_send, get_long_running_output, get_long_running_status) | ||
| def deserialization_cb(pipeline_response): | ||
| return json.loads(pipeline_response.http_response.text()) | ||
|
|
||
| request = client.post(url, query_parameters, header_parameters, **body_content_kwargs) | ||
| pipeline_response = client._pipeline.run(request, stream=False) | ||
|
|
||
| return LROPoller(client=client, initial_response=pipeline_response, deserialization_callback=deserialization_cb, | ||
| polling_method=ARMPolling(lro_options={"final-state-via": "azure-async-operation"})) |
There was a problem hiding this comment.
Could we still obtain the long running status after the migration?
There was a problem hiding this comment.
Yes, it looks the same as before.
jiasli
reviewed
Sep 29, 2024
| @@ -109,7 +109,7 @@ def internal_validate_lock_parameters(namespace, resource_group, resource_provid | |||
| parent_resource_path, resource_type, resource_name): | |||
| if resource_group is None: | |||
| if resource_name is not None: | |||
| from msrestazure.tools import parse_resource_id, is_valid_resource_id | |||
| from azure.mgmt.core.tools import parse_resource_id, is_valid_resource_id | |||
There was a problem hiding this comment.
I think this change is already covered by #29856.
jiasli
reviewed
Sep 29, 2024
There was a problem hiding this comment.
I have re-recorded the test that included the invoice-action command.
jiasli
reviewed
Sep 29, 2024
Comment on lines
4569
to
4576
| def deserialization_cb(pipeline_response): | ||
| return json.loads(pipeline_response.http_response.text()) | ||
|
|
||
| request = client.post(url, query_parameters, header_parameters, **body_content_kwargs) | ||
| pipeline_response = client._pipeline.run(request, stream=False) | ||
|
|
||
| return LROPoller(client=client, initial_response=pipeline_response, deserialization_callback=deserialization_cb, | ||
| polling_method=ARMPolling(lro_options={"final-state-via": "azure-async-operation"})) |
There was a problem hiding this comment.
I am not an expert on this part, but this process seems to be pretty generic. Do we have to re-define the whole LRO process?
jiasli
reviewed
Sep 29, 2024
| pipeline_response = client._pipeline.run(request, stream=False) | ||
|
|
||
| return LROPoller(client=client, initial_response=pipeline_response, deserialization_callback=deserialization_cb, | ||
| polling_method=ARMPolling(lro_options={"final-state-via": "azure-async-operation"})) |
There was a problem hiding this comment.
I understand the name azure-async-operation is from SDK (https://github.com/Azure/azure-sdk-for-python/blob/54b2d3701a530628d52936193c3a5f564fbbee73/sdk/core/azure-mgmt-core/azure/mgmt/core/polling/arm_polling.py#L69), but it is super confusing as the header name in the HTTP response is Azure-AsyncOperation as documented by https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/async-operations. azure-async-operation is never used in any place.
There was a problem hiding this comment.
It is an option to choose to get the final URL, I will not specify it and let it decide for itself.
jiasli
reviewed
Sep 29, 2024
| def deserialization_cb(pipeline_response): | ||
| return json.loads(pipeline_response.http_response.text()) | ||
|
|
||
| request = client.post(url, query_parameters, header_parameters, **body_content_kwargs) |
There was a problem hiding this comment.
I am surprised that SDK has no equivalent function and we have to construct the POST request by ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az resource invoke-actionDescription
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.