[AKS] az aks upgrade: Support tier switch with AKS upgrade
#29448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenxuan0923
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @wenxuan0923, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks upgrade | cmd aks upgrade added parameter k8s_support_plan |
||
| aks upgrade | cmd aks upgrade added parameter tier |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
wenxuan0923
changed the title
wenxuan0923
changed the title
az aks upgrade: support tier switch with AKS upgrade
wenxuan0923
changed the title
az aks upgrade: support tier switch with AKS upgradeaz aks upgrade: Support tier switch with AKS upgrade
wenxuan0923
force-pushed
the
wenx/update-az-upgrade
branch
2 times, most recently
from
a6c93cb
to
05fd984
Compare
FumingZhang
reviewed
Jul 24, 2024
There was a problem hiding this comment.
lgtm
Queued live test to validate the change, test passed!
- test_aks_upgrade_with_tier_switch
Comment on lines
+864
to
+870
| if tier is not None: | ||
| instance.sku.tier = tier | ||
|
|
||
| if k8s_support_plan is not None: | ||
| instance.support_plan = k8s_support_plan |
There was a problem hiding this comment.
Is it necessary to add validation about lts tier requires premium sku?
There was a problem hiding this comment.
@FumingZhang thanks for reviewing! Yes, we can add it here or rely on the validation on the server side. I just updated the code to raise CLIError for it on L872.
There was a problem hiding this comment.
There was a problem hiding this comment.
I am having an issue on L872. shouldn't it be instance.sku.tier not instance.tier?
There was a problem hiding this comment.
@sdrinovsky thanks for bringing this to my attention, I started a PR to get it fixed #29949
|
PR #29436 just merged, which updated the default API version used by the command group, you'll need to update the recording file to pass the CI. Please also rebase from dev branch to pick up the change. |
wenxuan0923
force-pushed
the
wenx/update-az-upgrade
branch
from
9632eb2
to
4387588
Compare
|
PR rebased to the latest dev branch |
zhoxing-ms
approved these changes
Jul 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks upgradeDescription
Adding options
--tierand--k8s-support-plantoaz aks upgradecommand to support enable/disable AKSLongTermSupport with upgrade operation.For example, if a cluster is currently on version 1.26, they can upgrade to 1.27 LTS with command:
az aks upgrade -g myResourceGroup -n myCluster -k 1.27 --tier Premium --k8s-support-plan AKSLongTermSupportSimilarly, to exit LTS for clusters on 1.27, they can do:
az aks upgrade -g myResourceGroup -n myCluster -k 1.28 --tier Standard --k8s-support-plan KubernetesOfficialTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.