[load][CCOA] support multi-region load test configuration | bug fix | refactor 1.0 #8350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| load test create | cmd load test create added parameter regionwise_engines |
||
| load test update | cmd load test update added parameter regionwise_engines |
|
Hi @mbhardwaj-msft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
mbhardwaj-msft
changed the title
prativen
reviewed
Nov 29, 2024
mbhardwaj-msft
commented
Nov 29, 2024
mbhardwaj-msft
commented
Nov 29, 2024
src/load/azext_load/tests/latest/resources/config-regionwise-engines-no-parent-region.yaml
Show resolved
Hide resolved
src/load/azext_load/tests/latest/test_load_test_regional_load.py
Outdated
Show resolved
Hide resolved
mitsha-microsoft
approved these changes
Dec 2, 2024
|
🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA |
mbhardwaj-msft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.