Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Detect failed Update App operation during polling #8349

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Spring] Detect failed Update App operation during polling #8349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01b90f4
fix: Detect Failed operation during polling
domainname Nov 28, 2024
d06e1ad
updatez
domainname Nov 28, 2024
4057e70
update history & version
domainname Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/spring/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
Release History
===============
1.26.1
---
* Fix command `az spring app update`, so that it can detect update failure and return error message.

1.26.0
---
* Remove `Preview` tag for config server features in Enterprise tier.
Expand Down Expand Up @@ -30,7 +34,7 @@ Release History

1.24.1
---
* Add command group `az spring private-dns-zone` to configure constumer private DNS zone with Azure Spring Apps.
* Add command group `az spring private-dns-zone` to configure customer private DNS zone with Azure Spring Apps.
* Add new command `az spring private-dns-zone add`, `az spring private-dns-zone update` and `az spring private-dns-zone clean`

1.24.0
Expand Down
5 changes: 5 additions & 0 deletions src/spring/azext_spring/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,11 @@ def app_update(cmd, client, resource_group, service, name,
if no_wait:
return
wait_till_end(cmd, *pollers)

for p in pollers:
if p.status() == 'Failed' and isinstance(p.result(), Exception):
raise p.result()
domainname marked this conversation as resolved.
Show resolved Hide resolved

return app_get(cmd, client, resource_group, service, name)


Expand Down
2 changes: 1 addition & 1 deletion src/spring/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.
VERSION = '1.26.0'
VERSION = '1.26.1'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down
Loading