Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-09-01-preview update #8335

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jamesfan1
Copy link
Member

@jamesfan1 jamesfan1 commented Nov 27, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 27, 2024

❌Azure CLI Extensions Breaking Change Test
❌nginx
rule cmd_name rule_message suggest_message
1007 - ParaRemove nginx deployment configuration create cmd nginx deployment configuration create removed parameter location please add back parameter location for cmd nginx deployment configuration create
1007 - ParaRemove nginx deployment configuration update cmd nginx deployment configuration update removed parameter location please add back parameter location for cmd nginx deployment configuration update
1007 - ParaRemove nginx deployment update cmd nginx deployment update removed parameter location please add back parameter location for cmd nginx deployment update
⚠️ 1011 - SubgroupAdd nginx deployment api-key sub group nginx deployment api-key added

Copy link

Hi @jamesfan1,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 27, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

@necusjz
Copy link
Member

necusjz commented Nov 27, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Nov 28, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@@ -3,6 +3,10 @@
Release History
===============

2.0.0b6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2.0.0b7 (consistent with setup.py)

@necusjz
Copy link
Member

necusjz commented Nov 28, 2024

❌Azure CLI Extensions Breaking Change Test

❌nginx

rule
cmd_name
rule_message
suggest_message

1007 - ParaRemove
nginx deployment configuration create
cmd nginx deployment configuration create removed parameter location
please add back parameter location for cmd nginx deployment configuration create

1007 - ParaRemove
nginx deployment configuration update
cmd nginx deployment configuration update removed parameter location
please add back parameter location for cmd nginx deployment configuration update

1007 - ParaRemove
nginx deployment update
cmd nginx deployment update removed parameter location
please add back parameter location for cmd nginx deployment update

⚠️ 1011 - SubgroupAdd
nginx deployment api-key
sub group nginx deployment api-key added

are they as expected?

@jamesfan1
Copy link
Member Author

jamesfan1 commented Dec 2, 2024

@necusjz
These changes are expected

@necusjz
Copy link
Member

necusjz commented Dec 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants