[containerapp] Add new options for labels mode #8324
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @Tratcher, |
|
Hi @Tratcher, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Tratcher Release SuggestionsModule: containerapp
Notes
|
| if ingress and not target_port and target_port != 0: | ||
| target_port = 0 | ||
| logger.warning("No target-port provided, defaulting to auto-detect. Try `az containerapp up --ingress %s --target-port <port>` to set a custom port.", ingress) |
There was a problem hiding this comment.
A small bugfix for my prior feature 😁.
|
Hi @Greedygre |
| * 'az containerapp create': New target-label option for Labels revision mode. | ||
| * 'az containerapp update': New revisions-mode and target-label options for Labels revision mode. | ||
| * 'az containerapp up': New revisions-mode and target-label options for Labels revision mode. |
There was a problem hiding this comment.
Should the customer use sub command group for this property?
|
please make sure all checks in CI passed. If the PR is to add new feature support, please get approval from your team who could be responsible for your business logic. |
This adds support for the new containerapp activeRevisionMode 'labels' mode and the associated target-label option. These are used when creating or updating applications. There are also new commands to show the history of label revision assignments.
All commands except label-history already exist and need to be overridden by the extension to support these new features.
Needs tests.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)