Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firewall] az network firewall create: add support public-ip for vhub sku firewall #8253

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Nov 8, 2024

resolve: Azure/azure-cli#29854
[Network] Add support for Azure Firewall Byopip feature


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 8, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Pan-Qi,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 8, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 8, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@Pan-Qi Pan-Qi marked this pull request as draft November 8, 2024 06:26
Copy link

github-actions bot commented Nov 8, 2024

@Pan-Qi Pan-Qi force-pushed the bernard-add-firewall-byopip-feature branch from 7cfcbf2 to 90b4d55 Compare November 14, 2024 05:53
@Pan-Qi Pan-Qi changed the title regenerate firewall create [Firewall] az network firewall create: add support public-ip for vhub sku firewall Nov 19, 2024
@Pan-Qi Pan-Qi marked this pull request as ready for review November 19, 2024 02:27
@necusjz
Copy link
Member

necusjz commented Nov 19, 2024

Hi @Pan-Qi

Release Suggestions

Module: azure-firewall

  • Please log updates into to src/azure-firewall/HISTORY.rst
  • Update VERSION to 1.2.2 in src/azure-firewall/setup.py

Notes

we need to update them to trigger a release

@necusjz necusjz merged commit eb8290c into main Nov 19, 2024
21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ azure-firewall ] : https://dev.azure.com/azclitools/release/_build/results?buildId=207083&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure Firewall Byopip feature
4 participants