Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Connector] fix function enable_mi_for_db_linker with extra args #8252

Closed
wants to merge 4 commits into from
Closed

[Service Connector] fix function enable_mi_for_db_linker with extra args #8252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ca8b82
fix adding args to enable_mi_for_db_linker
Nov 8, 2024
8e69dee
fix adding args to enable_mi_for_db_linker
Nov 8, 2024
8ce98f2
fix adding args to enable_mi_for_db_linker
Nov 8, 2024
6e2a621
fix azdev style issue
Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/serviceconnector-passwordless/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
3.1.3
++++++
* Fix argument missing

3.1.2
++++++
* Update dependencies
Expand Down
6 changes: 5 additions & 1 deletion src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@
# For db(mysqlFlex/psql/psqlFlex/sql) linker with auth type=systemAssignedIdentity, enable Microsoft Entra auth and create db user on data plane
# For other linker, ignore the steps
def get_enable_mi_for_db_linker_func(yes=False, new=False):
def enable_mi_for_db_linker(cmd, source_id, target_id, auth_info, client_type, connection_name):
def enable_mi_for_db_linker(cmd, source_id, target_id, auth_info, client_type, connection_name, *args, **kwargs):
# azdev style requires all args to be used, this is a workaround
_ = args
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove and add unused-argument in pylint

_ = kwargs

# return if connection is not for db mi
if auth_info['auth_type'] not in [AUTHTYPES[AUTH_TYPE.SystemIdentity],
AUTHTYPES[AUTH_TYPE.UserIdentity],
Expand Down
2 changes: 1 addition & 1 deletion src/serviceconnector-passwordless/azext_serviceconnector_passwordless/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
# --------------------------------------------------------------------------------------------


VERSION = '3.1.2'
VERSION = '3.1.3'
NAME = 'serviceconnector-passwordless'
2 changes: 1 addition & 1 deletion src/serviceconnector-passwordless/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
logger.warn("Wheel is not available, disabling bdist_wheel hook")


VERSION = '3.1.2'
VERSION = '3.1.3'
try:
from azext_serviceconnector_passwordless.config import VERSION
except ImportError:
Expand Down
Loading