-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989
Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
network manager ipam-pool | sub group network manager ipam-pool added |
||
network manager security-admin-config create | cmd network manager security-admin-config create added parameter network_group_address_space_aggregation_option |
||
network manager security-admin-config rule-collection rule create | cmd network manager security-admin-config rule-collection rule create update parameter kind : added property default=Custom |
||
network manager security-admin-config rule-collection rule create | cmd network manager security-admin-config rule-collection rule create update parameter kind : removed property required=True |
||
network manager security-admin-config update | cmd network manager security-admin-config update added parameter network_group_address_space_aggregation_option |
||
network manager verifier-workspace | sub group network manager verifier-workspace added |
Hi @danlope, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
src/network-manager/azext_network_manager/tests/latest/test_network_scenario.py
Outdated
Show resolved
Hide resolved
|
src/network-manager/azext_network_manager/tests/latest/test_network_scenario.py
Outdated
Show resolved
Hide resolved
@danlope your pr removed option |
src/network-manager/azext_network_manager/aaz/latest/network/manager/ipam_pool/_create.py
Show resolved
Hide resolved
…verwriteExistingCassetteException (?)
…into feature-ipam-vnv-2024-01-01-preview
…into feature-ipam-vnv-2024-01-01-preview
we need to update |
… failure, even with same v in HISTORY.rst and setup.py
…into feature-ipam-vnv-2024-01-01-preview
…er_help: added help details to desc
[Release] Update index.json for extension [ network-manager ] : https://dev.azure.com/azclitools/release/_build/results?buildId=194310&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.