Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989

Merged
merged 28 commits into from
Oct 2, 2024

Conversation

danlope
Copy link
Contributor

@danlope danlope commented Sep 17, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 17, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️network-manager
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd network manager ipam-pool sub group network manager ipam-pool added
⚠️ 1006 - ParaAdd network manager security-admin-config create cmd network manager security-admin-config create added parameter network_group_address_space_aggregation_option
⚠️ 1008 - ParaPropAdd network manager security-admin-config rule-collection rule create cmd network manager security-admin-config rule-collection rule create update parameter kind: added property default=Custom
⚠️ 1009 - ParaPropRemove network manager security-admin-config rule-collection rule create cmd network manager security-admin-config rule-collection rule create update parameter kind: removed property required=True
⚠️ 1006 - ParaAdd network manager security-admin-config update cmd network manager security-admin-config update added parameter network_group_address_space_aggregation_option
⚠️ 1011 - SubgroupAdd network manager verifier-workspace sub group network manager verifier-workspace added

Copy link

Hi @danlope,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 17, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 17, 2024

@AllyW AllyW added the preview release extension module as preview label Sep 19, 2024
@AllyW
Copy link
Member

AllyW commented Sep 19, 2024

❌Azure CLI Extensions Breaking Change Test

❌network-manager

rule
cmd_name
rule_message
suggest_message

1010 - ParaPropUpdate
network manager security-admin-config create
cmd network manager security-admin-config create update parameter network_manager_name: updated property options from ['--name', '--network-manager-name', '-n'] to ['--manager-name', '--network-manager-name']
please change property options from ['--manager-name', '--network-manager-name'] to ['--name', '--network-manager-name', '-n'] for parameter network_manager_name of cmd network manager security-admin-config create

1010 - ParaPropUpdate
network manager security-admin-config update
cmd network manager security-admin-config update update parameter network_manager_name: updated property options from ['--name', '--network-manager-name', '-n'] to ['--manager-name', '--network-manager-name']
please change property options from ['--manager-name', '--network-manager-name'] to ['--name', '--network-manager-name', '-n'] for parameter network_manager_name of cmd network manager security-admin-config update

⚠️ 1011 - SubgroupAdd
network manager ipam-pool
sub group network manager ipam-pool added

⚠️ 1006 - ParaAdd
network manager security-admin-config create
cmd network manager security-admin-config create added parameter network_group_address_space_aggregation_option

⚠️ 1010 - ParaPropUpdate
network manager security-admin-config create
cmd network manager security-admin-config create update parameter configuration_name: updated property options from ['--configuration-name'] to ['--configuration-name', '--name', '-n']

⚠️ 1006 - ParaAdd
network manager security-admin-config update
cmd network manager security-admin-config update added parameter network_group_address_space_aggregation_option

⚠️ 1010 - ParaPropUpdate
network manager security-admin-config update
cmd network manager security-admin-config update update parameter configuration_name: updated property options from ['--configuration-name'] to ['--configuration-name', '--name', '-n']

⚠️ 1011 - SubgroupAdd
network manager verifier-workspace
sub group network manager verifier-workspace added

@danlope your pr removed option -n for parameter network_manager_name of cmd network manager security-admin-config create. This is a breaking change and please confirm this change.

@AllyW AllyW added minor release extension module with version minor upgraded skip-cal-version and removed skip-cal-version preview release extension module as preview minor release extension module with version minor upgraded labels Sep 19, 2024
@necusjz
Copy link
Member

necusjz commented Sep 29, 2024

Hi @danlope

Release Suggestions

Module: network-manager

  • Update VERSION to 1.3.0 in src/network-manager/setup.py

Notes

we need to update setup.py to release an extension with new version

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 30, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 1, 2024
@necusjz necusjz merged commit 580e2fe into Azure:main Oct 2, 2024
20 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Oct 2, 2024

[Release] Update index.json for extension [ network-manager ] : https://dev.azure.com/azclitools/release/_build/results?buildId=194310&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants