Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Azure Bastion} sdk update for bastion extension #7955

Merged
merged 25 commits into from
Sep 20, 2024

Conversation

aavalang
Copy link
Member

@aavalang aavalang commented Sep 5, 2024


Bumping up SDK from 2022-01-01 to 2024-01-01 to accomodate new features

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 5, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️bastion
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network bastion create cmd network bastion create added parameter enable_file_copy
⚠️ 1006 - ParaAdd network bastion create cmd network bastion create added parameter enable_kerberos
⚠️ 1006 - ParaAdd network bastion create cmd network bastion create added parameter enable_session_recording
⚠️ 1006 - ParaAdd network bastion create cmd network bastion create added parameter enable_shareable_link
⚠️ 1006 - ParaAdd network bastion create cmd network bastion create added parameter zones
⚠️ 1010 - ParaPropUpdate network bastion create cmd network bastion create update parameter name: updated property name from name to bastion_host_name
⚠️ 1008 - ParaPropAdd network bastion create cmd network bastion create update parameter scale_units: added property aaz_default=2
⚠️ 1008 - ParaPropAdd network bastion create cmd network bastion create update parameter scale_units: added property default=2
⚠️ 1010 - ParaPropUpdate network bastion create cmd network bastion create update parameter sku: updated property choices from ['Basic', 'Standard'] to ['Basic', 'Premium', 'Standard']
⚠️ 1006 - ParaAdd network bastion delete cmd network bastion delete added parameter yes
⚠️ 1010 - ParaPropUpdate network bastion delete cmd network bastion delete update parameter name: updated property name from name to bastion_host_name
⚠️ 1006 - ParaAdd network bastion list cmd network bastion list added parameter pagination_limit
⚠️ 1006 - ParaAdd network bastion list cmd network bastion list added parameter pagination_token
⚠️ 1010 - ParaPropUpdate network bastion show cmd network bastion show update parameter name: updated property name from name to bastion_host_name
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter dns_name
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter enable_file_copy
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter enable_kerberos
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter enable_session_recording
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter enable_shareable_link
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter ip_configurations
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter location
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter network_acls
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter tags
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter virtual_network
⚠️ 1006 - ParaAdd network bastion update cmd network bastion update added parameter zones
⚠️ 1010 - ParaPropUpdate network bastion update cmd network bastion update update parameter name: updated property name from name to bastion_host_name
⚠️ 1010 - ParaPropUpdate network bastion update cmd network bastion update update parameter name: updated property options from ['--name', '-n'] to ['--bastion-host-name', '--name', '-n']
⚠️ 1008 - ParaPropAdd network bastion update cmd network bastion update update parameter sku: added property nargs=+
⚠️ 1009 - ParaPropRemove network bastion update cmd network bastion update update parameter sku: removed property choices=['Basic', 'Standard']
⚠️ 1010 - ParaPropUpdate network bastion update cmd network bastion update update parameter sku: updated property aaz_type from string to AAZObjectArg
⚠️ 1010 - ParaPropUpdate network bastion update cmd network bastion update update parameter sku: updated property type from string to Object
⚠️ 1010 - ParaPropUpdate network bastion wait cmd network bastion wait update parameter name: updated property name from name to bastion_host_name
⚠️ 1010 - ParaPropUpdate network bastion wait cmd network bastion wait update parameter name: updated property options from ['--name', '-n'] to ['--bastion-host-name', '--name', '-n']

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 5, 2024

Azure Bastion

Copy link

github-actions bot commented Sep 5, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 5, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 5, 2024
@aavalang aavalang changed the title {Azure Bastion} sdk update for az cli {Azure Bastion} sdk update for bastion extension Sep 5, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 5, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 12, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 12, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 12, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 12, 2024
necusjz
necusjz previously approved these changes Sep 13, 2024
@necusjz necusjz dismissed their stale review September 13, 2024 16:12

by mistake

@necusjz necusjz merged commit 5fa074d into Azure:main Sep 20, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ bastion ] : https://dev.azure.com/azclitools/release/_build/results?buildId=191129&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants