Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confcom] Updating katapolicygen to support new node image #7849

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

SethHollandsworth
Copy link
Contributor

Also updating tests to use images hosted on MCR instead of Docker Hub

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 2, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️confcom
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd confcom katapolicygen cmd confcom katapolicygen added parameter containerd_pull
⚠️ 1006 - ParaAdd confcom katapolicygen cmd confcom katapolicygen added parameter containerd_socket_path
⚠️ 1006 - ParaAdd confcom katapolicygen cmd confcom katapolicygen added parameter print_version
⚠️ 1006 - ParaAdd confcom katapolicygen cmd confcom katapolicygen added parameter rules_file_name
⚠️ 1009 - ParaPropRemove confcom katapolicygen cmd confcom katapolicygen update parameter yaml_path: removed property required=True

Copy link

Hi @SethHollandsworth,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 2, 2024

confcom

Copy link

github-actions bot commented Aug 2, 2024

⚠️ Release Suggestions

Module: confcom

  • ⚠️ Please update VERSION to be 1.0.0 in src/confcom/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 2, 2024
@yonzhan yonzhan requested a review from kairu-ms August 3, 2024 00:33
@yonzhan yonzhan requested a review from jsntcy August 3, 2024 00:33
@kairu-ms kairu-ms removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 5, 2024
@kairu-ms kairu-ms merged commit d554ce1 into Azure:main Aug 5, 2024
21 of 22 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 5, 2024

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/release/_build/results?buildId=178704&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants