Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 regression: Segfault in initiate_socket_connection (socketio_berkeley) when DNS resolution fails (gh#636) #637

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Fix IPv6 regression: Segfault in initiate_socket_connection (socketio_berkeley) when DNS resolution fails (gh#636) #637

merged 3 commits into from
Aug 2, 2023

Conversation

ewertons
Copy link
Contributor

@ewertons ewertons commented Jul 31, 2023 •
edited
Loading

Addresses #636

Note: there are no active unit tests for socketio_berkeley.

CIPop
CIPop requested changes Jul 31, 2023
View reviewed changes
Copy link
Member

@CIPop CIPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're still missing a check.
Ideally, we would need a UT to confirm we're able to react to errors at all levels.

adapters/socketio_berkeley.c Show resolved Hide resolved
@ewertons ewertons requested a review from CIPop August 1, 2023 06:19
CIPop
CIPop approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@CIPop CIPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ewertons !

@RLeclair will manually verify we have not missed anything by simulating errors in a debugger (since adding UTs would be a larger project).

adapters/socketio_berkeley.c Show resolved Hide resolved
adapters/socketio_berkeley.c Show resolved Hide resolved
@RLeclair RLeclair merged commit 8ee0e5d into master Aug 2, 2023
20 checks passed
@RLeclair RLeclair deleted the ewertons/gh636 branch August 2, 2023 17:50
@RLeclair RLeclair changed the title Fix for Segfault in initiate_socket_connection (socketio_berkeley) when DNS resolution fails (gh#636) Fix IPv6 regression: Segfault in initiate_socket_connection (socketio_berkeley) when DNS resolution fails (gh#636) Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CIPop CIPop CIPop approved these changes

@RLeclair RLeclair Awaiting requested review from RLeclair

@vaavva vaavva Awaiting requested review from vaavva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewertons @CIPop @RLeclair