Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for domain join error if domain join user account is already in Administrators group #728

Merged
merged 11 commits into from
Dec 20, 2024

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Dec 20, 2024

Overview/Summary

Closes #727
Closes #729

This PR fixes/adds/changes/removes

  1. Checks if the domain join user account is already in the local Administrators group before attempting to add.
  2. Some typos are fixed.

Breaking Changes

N/A

Testing Evidence

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@SvenAelterman SvenAelterman marked this pull request as draft December 20, 2024 00:56
@SvenAelterman
Copy link
Contributor Author

Working in also fixing #729

@SvenAelterman
Copy link
Contributor Author

Closes #729 also.

I observed errors deleting the zip file and the simple fix of deleting the nested zip file seems to have resolved it. I am unsure why it would matter though.

@SvenAelterman SvenAelterman marked this pull request as ready for review December 20, 2024 01:20
@danycontre danycontre merged commit 0ed7f5a into Azure:main Dec 20, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants