Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support | and other special characters in domain join password #518

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Oct 25, 2023

Overview/Summary

Wrap domain join password in ' in the PowerShell command.

This PR fixes/adds/changes/removes

  1. Fixes Domain Join Password cannot contain | (and possibly other characters too) #515

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@danycontre danycontre changed the base branch from main to credentials-characters October 26, 2023 12:43
@danycontre
Copy link
Collaborator

@SvenAelterman thanks for your contribution, merging on feature branch for testing.

@danycontre danycontre merged commit ffc2c46 into Azure:credentials-characters Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain Join Password cannot contain | (and possibly other characters too)
2 participants