Add Azure Firewall as an option - Bicep code development

.gitignore

@@ -55,4 +55,5 @@ Deploy-Baseline.ps1
 workload/bicep/parameters/deploy-baseline-parameters-MSA.json
 
 # local test files
-localTest
+localTest
+

carml/1.3.0/Microsoft.Insights/scheduledQueryRules/deploy.bicep

@@ -4,6 +4,9 @@ param name string
 @description('Optional. Location for all resources.')
 param location string = resourceGroup().location
 
+@description('Optional. The display name of the scheduled query rule.')
+param alertDisplayName string = ''
+
 @description('Optional. The description of the scheduled query rule.')
 param alertDescription string = ''
 
@@ -91,7 +94,7 @@ resource queryRule 'Microsoft.Insights/scheduledQueryRules@2021-02-01-preview' =
     autoMitigate: (kind == 'LogAlert') ? autoMitigate : null
     criteria: criterias
     description: alertDescription
-    displayName: name
+    displayName: !empty(alertDisplayName) ? alertDisplayName : name
     enabled: enabled
     evaluationFrequency: (kind == 'LogAlert' && !empty(evaluationFrequency)) ? evaluationFrequency : null
     muteActionsDuration: (kind == 'LogAlert' && !empty(suppressForMinutes)) ? suppressForMinutes : null

carml/1.3.0/Microsoft.Insights/scheduledQueryRules/readme.md

@@ -32,6 +32,7 @@ This module deploys a scheduled query rule.
 | Parameter Name | Type | Default Value | Allowed Values | Description |
 | :-- | :-- | :-- | :-- | :-- |
 | `actions` | array | `[]` |  | Actions to invoke when the alert fires. |
+| `alertDisplayName` | string | `''` |  | The display name of the scheduled query rule. |
 | `alertDescription` | string | `''` |  | The description of the scheduled query rule. |
 | `autoMitigate` | bool | `True` |  | The flag that indicates whether the alert should be automatically resolved or not. Relevant only for rules of the kind LogAlert. |
 | `enabled` | bool | `True` |  | The flag which indicates whether this scheduled query rule is enabled. |
@@ -213,6 +214,7 @@ module scheduledQueryRules './Microsoft.Insights/scheduledQueryRules/deploy.bice
     ]
     // Non-required parameters
     alertDescription: 'My sample Alert'
+    alertDisplayName: 'My alert friendly name'
     autoMitigate: false
     enableDefaultTelemetry: '<enableDefaultTelemetry>'
     evaluationFrequency: 'PT5M'
@@ -290,6 +292,9 @@ module scheduledQueryRules './Microsoft.Insights/scheduledQueryRules/deploy.bice
     "alertDescription": {
       "value": "My sample Alert"
     },
+    "alertDisplayName": {
+      "value": "My alert friendly name"
+    },
     "autoMitigate": {
       "value": false
     },

carml/1.3.0/Microsoft.Network/azureFirewalls/deploy.bicep

@@ -50,11 +50,12 @@ param virtualHubId string = ''
 param threatIntelMode string = 'Deny'
 
 @description('Optional. Zone numbers e.g. 1,2,3.')
-param zones array = [
-  '1'
-  '2'
-  '3'
-]
+param zones array = []
+// param zones array = [
+//   '1'
+//   '2'
+//   '3'
+// ]
 
 @description('Optional. Diagnostic Storage Account resource identifier.')
 param diagnosticStorageAccountId string = ''
@@ -222,7 +223,7 @@ module publicIPAddress '../../Microsoft.Network/publicIPAddresses/deploy.bicep'
     ]
     location: location
     diagnosticStorageAccountId: diagnosticStorageAccountId
-    diagnosticLogsRetentionInDays: diagnosticLogsRetentionInDays
+    //diagnosticLogsRetentionInDays: diagnosticLogsRetentionInDays
     diagnosticWorkspaceId: diagnosticWorkspaceId
     diagnosticEventHubAuthorizationRuleId: diagnosticEventHubAuthorizationRuleId
     diagnosticEventHubName: diagnosticEventHubName