Replace AAD/ Add Microsoft Entra ID #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danycontre
reviewed
Oct 3, 2023
| @@ -10,7 +10,7 @@ Follow the steps below to troubleshoot and resolve the issue: | |||
|
|
|||
| ### Validate environment and account configuration | |||
|
|
|||
| - **Check Configuration**: Review your Azure Virtual Desktop (AVD) virtual network configuration and ensure that DNS is properly configured and the virtual network is peered to the network Hub or Identity Services virtual network. When using AD DS or AAD DS commonly the virtual network will need to be setup with custom DNS servers settings that point to the domain controllers IPs. | |||
There was a problem hiding this comment.
AAD DS service hasn't been renamed to the new Microsoft Entra ID model, for now let's keep AAD DS
There was a problem hiding this comment.
@roarrioj this one seems to be pending for updates.
danycontre
reviewed
Oct 3, 2023
| @@ -11,7 +11,7 @@ | |||
| - **Environment** – Deployment Environment type (Development/Test/Production), will be used for naming and tagging purposes. | |||
| - **Identity provider** blade | |||
| - **Identity Service Provider** - Identity service provider (AD DS, AAD DS, AAD) that already exists and will be used for Azure Virtual Desktop. | |||
| - Microsoft Entra ID (AAD). | |||
| - Microsoft Entra ID. | |||
| - Active Directory (AD DS). | |||
| - Microsoft Entra ID Domain Services (AAD DS). | |||
There was a problem hiding this comment.
AAD DS service hasn't been renamed to the new Microsoft Entra ID model, for now let's keep Azure AD DS (AAD DS)
danycontre
reviewed
Oct 3, 2023
| @@ -1,4 +1,4 @@ | |||
| # Implement Azure Virtual Desktop with Azure Active Directory | |||
There was a problem hiding this comment.
"Azure" needs to be removed, the new service name is "Microsoft Entra ID" not "Azure Microsoft Entra ID"
danycontre
requested changes
Oct 3, 2023
There was a problem hiding this comment.
@roarrioj thanks for your contribution.
Please take a look at the comments and adjust the PR.
roarrioj
commented
Oct 4, 2023
petersonjdNIH
pushed a commit
to ARPA-H/avdaccelerator-nih
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch